src: remove `--experimental-worker` env option by HarshithaKP · Pull Request #31577 · nodejs/node · GitHub
Skip to content

src: remove --experimental-worker env option#31577

Closed
HarshithaKP wants to merge 1 commit into
nodejs:masterfrom
HarshithaKP:worker_flag_source
Closed

src: remove --experimental-worker env option#31577
HarshithaKP wants to merge 1 commit into
nodejs:masterfrom
HarshithaKP:worker_flag_source

Conversation

@HarshithaKP

@HarshithaKP HarshithaKP commented Jan 30, 2020

Copy link
Copy Markdown
Member

worker is stable in the master, the flag is
no more required.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@HarshithaKP
src: remove --experimental-worker flag
385bc09 
worker is stable in the master, the flag is
no more required.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2020
@HarshithaKP

HarshithaKP commented Jan 30, 2020

Copy link
Copy Markdown
Member Author

@richardlau

richardlau commented Jan 30, 2020

Copy link
Copy Markdown
Member

workers are still experimental in 10.x and requires the flag there. #25361 made the flag a no-op rather than removing it. Not having the flag in master means that scripts that pass --experimental-worker to node would work on Node.js 10 but break on a version of Node.js where the flag has been removed.

I'd prefer to keep the flag as a no-op until 10.x becomes End-of-Life.

@richardlau

richardlau commented Jan 30, 2020

Copy link
Copy Markdown
Member

or @addaleax would we consider taking workers out of experimental for 10.x before it goes into maintenance in April?

@richardlau richardlau added the worker Issues and PRs related to Worker support. label Jan 30, 2020
@addaleax

addaleax commented Jan 30, 2020

Copy link
Copy Markdown
Member

addaleax
addaleax requested changes Jan 30, 2020
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making my -1 explicit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax requested changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HarshithaKP @richardlau @addaleax @nodejs-github-bot