{{ message }}
src: remove AsyncScope, AsyncCallbackScope, RunNextTicksNative#30236
Closed
addaleax wants to merge 4 commits into
Closed
src: remove AsyncScope, AsyncCallbackScope, RunNextTicksNative#30236addaleax wants to merge 4 commits into
addaleax wants to merge 4 commits into
Conversation
This allows removing custom code for setting the current async ids and running nextTicks.
Reduce the number of different scopes we use for async callbacks.
nodejs-github-bot
added
c++
Member
Author
fhinkel
approved these changes
Nov 3, 2019
devsnek
approved these changes
Nov 3, 2019
devnexen
reviewed
Nov 4, 2019
devnexen
approved these changes
Nov 4, 2019
addaleax
added
the
author ready
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
jasnell
approved these changes
Nov 6, 2019
addaleax
added a commit
that referenced
this pull request
Nov 6, 2019
This allows removing custom code for setting the current async ids and running nextTicks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Nov 6, 2019
Reduce the number of different scopes we use for async callbacks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
This allows removing custom code for setting the current async ids and running nextTicks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
Reduce the number of different scopes we use for async callbacks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Member
|
To land on v12.x, this should either wait for #29874, or be backported. |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 10, 2020
This allows removing custom code for setting the current async ids and running nextTicks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 10, 2020
Reduce the number of different scopes we use for async callbacks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
This allows removing custom code for setting the current async ids and running nextTicks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Reduce the number of different scopes we use for async callbacks. PR-URL: #30236 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 12, 2020
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Feb 14, 2020
3 tasks
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 15, 2020
Contributor
Member
Author
|
@MylesBorins I do think that our policy is, frankly, bad, if we prefer reverts on select branches to applying straightforward fixes. I’ll open an issue in nodejs/release, I think we should fix this sooner rather than later. For this particular PR, only the second commit here is problematic. You can feel free to remove the revert of the former. Also, it looks like you reverted on the staging branch, not the release branch. I assume that’s what you intended to do, but just in case it’s not, I thought I’d let you know. |
addaleax
added a commit
that referenced
this pull request
Feb 18, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2020
Contributor
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 18, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
* chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch nodejs/node#30862 * Fixup InternalCallbackScope patch nodejs/node#30236 * Fixup GN buildfiles patch nodejs/node#30755 * Fixup low-level hooks patch nodejs/node#30466 * Fixup globals require patch nodejs/node#31643 * Fixup process stream patch nodejs/node#30862 * Fixup js2c modification patch nodejs/node#30755 * Fixup internal fs override patch nodejs/node#30610 * Fixup context-aware warn patch nodejs/node#30336 * Fixup Node.js with ltcg config nodejs/node#29388 * Fixup oaepLabel patch nodejs/node#30917 * Remove redundant ESM test patch nodejs/node#30997 * Remove redundant cli flag patch nodejs/node#30466 * Update filenames.json * Remove macro generation in GN build files nodejs/node#30755 * Fix some compilation errors upstream * Add uvwasi to deps nodejs/node#30258 * Fix BoringSSL incompatibilities * Fixup linked module patch nodejs/node#30274 * Add missing sources to GN uv build libuv/libuv#2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch nodejs/node#30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly nodejs/node#30025 * Disable new esm syntax specs nodejs/node#30219 * Fixup v8 weakref hook spec nodejs/node#29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on nodejs/node#29777, and we don't override prepareStackTrace. * Disable new tls specs nodejs/node#23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: use callback scope for main script
This allows removing custom code for setting the current async ids
and running nextTicks.
src: remove AsyncScope and AsyncCallbackScope
Reduce the number of different scopes we use for async callbacks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes