{{ message }}
deps: remove thread_local to fix V8 compilation#22105
Closed
psmarshall wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
the
v8 engine
psmarshall
force-pushed
the
thread-local-fix
branch
from
1108cb6 to
a245736
Compare
Member
Contributor
Author
|
Yes, fine by me, I just didn't know which branch to target it to. Could you target the PR to the right place? I'm not able to change it 👍 |
Contributor
Author
|
Oh wait I figured out how to change the target branch. I'm not sure how to set this up. We want this to land with the V8 6.8 backport onto 10.x-staging - but I can't target this to 10.x-staging until v8 6.8 is in there (otherwise the patch makes no sense..). |
Member
|
My suggestion was to add this change to the 6.8 backport PR |
mhdawson
approved these changes
Aug 7, 2018
mhdawson
left a comment
mhdawson
left a comment
Member
There was a problem hiding this comment.
Assuming the V8 team are confident this does not have a negative impact. LTGM as it allows V8 6.8 to compile with OSX 1010 and provides an easier path for V8 6.8 landing in the 10.x line.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis should fix compilation on macOS 10.10, addressing these issues:
nodejs/build#1415
Fixes: nodejs/build#1426