iframe-proxy

psmarshall · 2018-07-30T12:03:04Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

[cpu-profiler] Add a new profiling mode with a more detailed call tree.
https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77

[cpu-profiler] Reuse free slots in code_entries_
https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a

[cpu-profiler] Only store deopt inline frames for functions that need it
https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b

[cpu-profiler] Use instruction start as the key for the CodeMap
https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66

psmarshall · 2018-07-30T12:05:09Z

ofrobots · 2018-08-01T18:50:03Z

/cc @nodejs/v8-update

EDIT:
CI: https://ci.nodejs.org/job/node-test-pull-request/16130/
V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/

ofrobots · 2018-08-01T18:52:34Z

v8_embedder_string in common.gypi should be bumped (by 1).

psmarshall · 2018-08-03T11:21:29Z

Thanks, I've bumped v8_embedder_string

psmarshall · 2018-08-16T09:37:13Z

@ofrobots I've rebased now that V8 6.8 has landed on v10.x-staging, so we should be OK to land this so that it can be in the 10.10 release

BridgeAR

RSLGTM

bmeurer

LGTM (rubber-stamped)

targos · 2018-08-29T12:08:27Z

Any reason not to land this on the master branch?

psmarshall · 2018-08-29T14:07:34Z

@targos I don't see why not. I'll retarget it to master

[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66

targos · 2018-08-29T14:35:36Z

Thanks! CI: https://ci.nodejs.org/job/node-test-pull-request/16858/

targos · 2018-09-03T17:50:06Z

Landed in 8ac662e

[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>

targos · 2018-09-03T18:40:34Z

It turns out this change breaks V8 tests:

https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/nodes=ubuntu1604-intel-64,v8test=v8test/1651/console

14:15:07 ../../test/cctest/test-log.cc:741:59: error: non-virtual member function marked 'override' hides virtual member function
14:15:07     void CodeMoveEvent(i::AbstractCode* from, Address to) override {}
14:15:07                                                           ^
14:15:07 ../../src/code-events.h:86:16: note: hidden overloaded virtual function 'v8::internal::CodeEventListener::CodeMoveEvent' declared here: type mismatch at 2nd parameter ('v8::internal::AbstractCode *' vs 'v8::internal::Address' (aka 'unsigned long'))
14:15:07   virtual void CodeMoveEvent(AbstractCode* from, AbstractCode* to) = 0;
14:15:07                ^
14:15:07 ../../test/cctest/test-log.cc:750:5: error: variable type 'class (anonymous class at ../../test/cctest/test-log.cc:739:3)' is an abstract class
14:15:07   } code_event_logger;
14:15:07     ^
14:15:07 ../../src/code-events.h:86:16: note: unimplemented pure virtual method 'CodeMoveEvent' in ''
14:15:07   virtual void CodeMoveEvent(AbstractCode* from, AbstractCode* to) = 0;
14:15:07                ^
14:15:07 2 errors generated.

Edit: fix at #22677

Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: nodejs#22028 Refs: v8/v8@ba752ea

[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>

Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: nodejs#22028 Refs: v8/v8@ba752ea PR-URL: nodejs#22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

psmarshall · 2018-09-04T13:17:42Z

[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>

Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea PR-URL: #22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>

Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea PR-URL: #22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jul 30, 2018

psmarshall force-pushed the backport-cpu-profiler-to-v10.x branch from c5be937 to 406d2f6 Compare August 3, 2018 11:21

psmarshall changed the base branch from master to v10.x-staging August 3, 2018 11:30

rvagg force-pushed the v10.x-staging branch from 82830a8 to b1adb44 Compare August 16, 2018 01:42

psmarshall force-pushed the backport-cpu-profiler-to-v10.x branch from 406d2f6 to 4445b31 Compare August 16, 2018 09:35

BridgeAR approved these changes Aug 16, 2018

View reviewed changes

psmarshall mentioned this pull request Aug 22, 2018

[8.x] deps: V8: backport 20 CPU profiler commits from upstream #21558

Closed

2 tasks

psmarshall force-pushed the backport-cpu-profiler-to-v10.x branch from 4445b31 to fe2ada8 Compare August 29, 2018 09:04

bmeurer approved these changes Aug 29, 2018

View reviewed changes

psmarshall changed the base branch from v10.x-staging to master August 29, 2018 14:14

psmarshall force-pushed the backport-cpu-profiler-to-v10.x branch from fe2ada8 to 95072d7 Compare August 29, 2018 14:15

targos closed this Sep 3, 2018

targos added a commit to targos/node that referenced this pull request Sep 3, 2018

deps: fix V8 test regression

d8b470a

Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: nodejs#22028 Refs: v8/v8@ba752ea

targos mentioned this pull request Sep 3, 2018

deps: fix V8 test regression #22677

Closed

targos added dont-land-on-v6.x labels Sep 4, 2018

targos mentioned this pull request Sep 5, 2018

Release proposal: v10.10.0 #22716

Merged

This was referenced Sep 6, 2018

2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236

Closed

2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221

Closed

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

psmarshall commented Jul 30, 2018

Checklist

Uh oh!

psmarshall commented Jul 30, 2018

Uh oh!

ofrobots commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ofrobots commented Aug 1, 2018

Uh oh!

psmarshall commented Aug 3, 2018

Uh oh!

psmarshall commented Aug 16, 2018

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

bmeurer left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Aug 29, 2018

Uh oh!

psmarshall commented Aug 29, 2018

Uh oh!

targos commented Aug 29, 2018

Uh oh!

targos commented Sep 3, 2018

Uh oh!

targos commented Sep 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psmarshall commented Sep 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ofrobots commented Aug 1, 2018 •

edited

Loading

targos commented Sep 3, 2018 •

edited

Loading