{{ message }}
crypto: add test case for AES key wrapping#20587
Closed
yhwang wants to merge 1 commit into
Closed
Conversation
Add test cases for AES key wrapping and only detect output length in cipher case. The reason being is the returned output length is insufficient in AES key unwrapping case. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Member
Author
bnoordhuis
approved these changes
May 8, 2018
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
LGTM. Were you planning to bring this up with the upstream openssl project as well?
3 tasks
tniessen
approved these changes
May 8, 2018
jasnell
reviewed
May 8, 2018
| // For key wrapping algorithms, get output size by calling | ||
| // EVP_CipherUpdate() with null output. | ||
| if (mode == EVP_CIPH_WRAP_MODE && | ||
| if (kind_ == kCipher && mode == EVP_CIPH_WRAP_MODE && |
Member
There was a problem hiding this comment.
Is this change intended? If so, this likely should be a different commit.
Member
Author
There was a problem hiding this comment.
@jasnell this is needed. Sorry the title of this commit is a little misleading but I explained that I need the code change in the description
Member
Author
|
@bnoordhuis I will try it |
2 tasks
Member
Member
|
Landed in e3ceae7 |
targos
pushed a commit
that referenced
this pull request
May 12, 2018
Add test cases for AES key wrapping and only detect output length in cipher case. The reason being is the returned output length is insufficient in AES key unwrapping case. PR-URL: #20587 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
tniessen
pushed a commit
to tniessen/node
that referenced
this pull request
May 13, 2018
Add test cases for AES key wrapping and only detect output length in cipher case. The reason being is the returned output length is insufficient in AES key unwrapping case. PR-URL: nodejs#20587 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
Add test cases for AES key wrapping and only detect output length in cipher case. The reason being is the returned output length is insufficient in AES key unwrapping case. Backport-PR-URL: #20706 PR-URL: #20587 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add test cases for AES key wrapping and only detect output length in
cipher case. The reason being is the returned output length is
insufficient in AES key unwrapping case.
Signed-off-by: Yihong Wang yh.wang@ibm.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes