build: update arm minimum supported platform by gibfahn · Pull Request #19164 · nodejs/node · GitHub
Skip to content

build: update arm minimum supported platform#19164

Merged
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:arm-libc
Mar 9, 2018
Merged

build: update arm minimum supported platform#19164
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:arm-libc

Conversation

@gibfahn

@gibfahn gibfahn commented Mar 6, 2018

Copy link
Copy Markdown
Member

This is already true in practice.

Fixes: nodejs/build#1164

cc/ @nodejs/build @rvagg @gdams

@rvagg I'm not sure if this applies to arm (not arm64) as well.

@gibfahn gibfahn self-assigned this Mar 6, 2018
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Mar 6, 2018
@rvagg

rvagg commented Mar 6, 2018

Copy link
Copy Markdown
Member

@BridgeAR

BridgeAR commented Mar 6, 2018

Copy link
Copy Markdown
Member

I guess this list is actually difficult to properly maintain. Is there any way we could automate something that produces a list of supported systems and their minimum build versions?

@rvagg

rvagg commented Mar 7, 2018

Copy link
Copy Markdown
Member

@BridgeAR I guess an Ansible script or two to run across all our release- machines would get a pretty good picture? While we're at it the same thing could be run across all of test- to get a snapshot of what's actually in use.

@gibfahn

gibfahn commented Mar 7, 2018

Copy link
Copy Markdown
Member Author

I guess an Ansible script or two to run across all our release- machines would get a pretty good picture? While we're at it the same thing could be run across all of test- to get a snapshot of what's actually in use.

I think test- is probably more valuable than release- right? We don't actually check that node runs on the machines we build it on.

I guess in some cases we might have "experimental" or Tier 2 platforms that we build for but don't run CI on?

@gibfahn

gibfahn commented Mar 7, 2018

Copy link
Copy Markdown
Member Author

@rvagg I'm not sure if this applies to arm (not arm64) as well.

Correct for ARM64, not so much for other ARM.

Yeah, I figured that.

My vote would be for switching to a set of "these are the platforms we build and test on", but it seems wrong to leave the arm reference wrong. So how about I leave ARM as it was, and just change ARM64?

@rvagg

rvagg commented Mar 8, 2018

Copy link
Copy Markdown
Member

yeah, put a lid back on that can of worms

@gibfahn

gibfahn commented Mar 9, 2018

Copy link
Copy Markdown
Member Author

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gibfahn

gibfahn commented Mar 9, 2018

Copy link
Copy Markdown
Member Author

This is already true in practice.

PR-URL: nodejs#19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gibfahn gibfahn merged commit 099e621 into nodejs:master Mar 9, 2018
@gibfahn gibfahn deleted the arm-libc branch March 9, 2018 17:27
targos pushed a commit that referenced this pull request Mar 17, 2018
This is already true in practice.

PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Mar 18, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
This is already true in practice.

PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This is already true in practice.

PR-URL: nodejs#19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

jasnell commented Aug 17, 2018

Copy link
Copy Markdown
Member

BethGriggs pushed a commit that referenced this pull request Oct 30, 2018
This is already true in practice.

Backport-PR-URL: #23275
PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

glibc version on arm64

7 participants