Update test-http-set-cookies to use Countdown by Leko · Pull Request #17550 · nodejs/node · GitHub
Skip to content

Update test-http-set-cookies to use Countdown#17550

Closed
Leko wants to merge 1 commit into
nodejs:masterfrom
Leko:use_countdown_in_http-upgrade-server
Closed

Update test-http-set-cookies to use Countdown#17550
Leko wants to merge 1 commit into
nodejs:masterfrom
Leko:use_countdown_in_http-upgrade-server

Conversation

@Leko

@Leko Leko commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

Use Countdown class instead of nresponses in test-http-set-cookies.js

See also: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 8, 2017
@apapirovski

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

@Leko

Leko commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

@Leko Leko closed this Dec 8, 2017
@Leko Leko deleted the use_countdown_in_http-upgrade-server branch December 8, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Leko @apapirovski @nodejs-github-bot