test: fix flaky test-benchmark-events by Trott · Pull Request #17472 · nodejs/node · GitHub
Skip to content

test: fix flaky test-benchmark-events#17472

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-bench-events-test
Closed

test: fix flaky test-benchmark-events#17472
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-bench-events-test

Conversation

@Trott

@Trott Trott commented Dec 5, 2017

Copy link
Copy Markdown
Member

Make sure each benchmark file only ones one combination of options.
Allow for zero iterations for short benchmark.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark events

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 5, 2017
@Trott

Trott commented Dec 5, 2017

Copy link
Copy Markdown
Member Author

@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. labels Dec 5, 2017
@Trott

Trott commented Dec 5, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11891/

@Trott

Trott commented Dec 5, 2017

Copy link
Copy Markdown
Member Author

CI failure is no doubt unrelated build issue but here's a re-run: https://ci.nodejs.org/job/node-test-commit-linux-linked/609/

mhdawson
mhdawson approved these changes Dec 5, 2017
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit comment:

'only ones one combination of options'

otherwise LGTM

@Trott
test: fix flaky test-benchmark-events
394ace6 
Make sure each benchmark file only runs one combination of options.
Allow for zero iterations for short benchmark.
@Trott Trott force-pushed the fix-bench-events-test branch from 9ed8fb8 to 394ace6 Compare December 5, 2017 19:05
@Trott

Trott commented Dec 5, 2017

Copy link
Copy Markdown
Member Author

Typo in commit fixed. Thanks, @mhdawson!

@Trott

Trott commented Dec 5, 2017

Copy link
Copy Markdown
Member Author

(CI is good.)

@BridgeAR

BridgeAR commented Dec 6, 2017

Copy link
Copy Markdown
Member

I think this can land below the 48 hours.

@Trott

Trott commented Dec 6, 2017

Copy link
Copy Markdown
Member Author

@Trott Trott closed this Dec 6, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 6, 2017
@Trott
test: fix flaky test-benchmark-events
b3e5367 
Make sure each benchmark file only runs one combination of options.
Allow for zero iterations for short benchmark.

PR-URL: nodejs#17472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
test: fix flaky test-benchmark-events
71be0a4 
Make sure each benchmark file only runs one combination of options.
Allow for zero iterations for short benchmark.

PR-URL: #17472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
test: fix flaky test-benchmark-events
619cbc4 
Make sure each benchmark file only runs one combination of options.
Allow for zero iterations for short benchmark.

PR-URL: #17472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: fix flaky test-benchmark-events
d12d86e 
Make sure each benchmark file only runs one combination of options.
Allow for zero iterations for short benchmark.

PR-URL: #17472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
test: fix flaky test-benchmark-events
d0738fe 
Make sure each benchmark file only runs one combination of options.
Allow for zero iterations for short benchmark.

PR-URL: #17472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@Trott Trott deleted the fix-bench-events-test branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @BridgeAR @jasnell @cjihrig @mhdawson @gibfahn @nodejs-github-bot