{{ message }}
test: test-inspector-async-hook-setup-at-signal flag as flaky#16941
Closed
refack wants to merge 1 commit into
Closed
test: test-inspector-async-hook-setup-at-signal flag as flaky#16941refack wants to merge 1 commit into
test-inspector-async-hook-setup-at-signal flag as flaky#16941refack wants to merge 1 commit into
Conversation
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
refack
added
flaky-test
cjihrig
approved these changes
Nov 10, 2017
Contributor
Author
refack
changed the title
test-inspector-async-hook-setup-at-signal flag as flaky
gireeshpunathil
approved these changes
Nov 11, 2017
Member
|
Fast-tracking based on @refack 's request. We have seen this test causing random CI failures so makes sense to isolate before diagnosing |
Member
|
Landed in 074a5c7 , don't know why the commit is not appearing here! |
Member
|
ah, ok - the commit meta is missing! any clues what is the best way to fix it now? |
Member
|
you can add the metadata as a comment at 074a5c7. It's too late to force-push. |
gireeshpunathil
referenced
this pull request
Nov 13, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
Member
|
thanks @targos , done. |
Contributor
MylesBorins
referenced
this pull request
Dec 19, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017 PR-URL: #16941 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017 PR-URL: #16941 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Merged
This was referenced Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-inspector-async-hook-setup-at-signalis also flaky on VS2017Refs: #16771
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test,inspector,windows