src: handle uv_async_init() failure by bnoordhuis · Pull Request #15458 · nodejs/node · GitHub
Skip to content

src: handle uv_async_init() failure#15458

Closed
bnoordhuis wants to merge 4 commits into
nodejs:masterfrom
bnoordhuis:fix-coverity-warnings
Closed

src: handle uv_async_init() failure#15458
bnoordhuis wants to merge 4 commits into
nodejs:masterfrom
bnoordhuis:fix-coverity-warnings

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Sep 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

edit: plus additional cleanup.

CI: https://ci.nodejs.org/job/node-test-pull-request/10124/

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 18, 2017
@lpinca lpinca mentioned this pull request Sep 19, 2017
Closed
2 tasks
@BridgeAR

BridgeAR commented Sep 21, 2017

Copy link
Copy Markdown
Member

@BridgeAR BridgeAR closed this Sep 21, 2017
BridgeAR pushed a commit that referenced this pull request Sep 21, 2017
@bnoordhuis @BridgeAR
src: remove unused static variable
b210d61 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit that referenced this pull request Sep 21, 2017
@bnoordhuis @BridgeAR
src: handle uv_async_init() failure
dce2738 
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit that referenced this pull request Sep 21, 2017
@bnoordhuis @BridgeAR
src: return references from getters, not copies
3869dd2 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit that referenced this pull request Sep 21, 2017
@bnoordhuis @BridgeAR
src: constify PerformanceEntry data members
78339e2 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
lukaszewczak pushed a commit to lukaszewczak/node that referenced this pull request Sep 23, 2017
@bnoordhuis @lukaszewczak
src: remove unused static variable
60ce845 
PR-URL: nodejs#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
lukaszewczak pushed a commit to lukaszewczak/node that referenced this pull request Sep 23, 2017
@bnoordhuis @lukaszewczak
src: handle uv_async_init() failure
51a9cfc 
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

PR-URL: nodejs#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
lukaszewczak pushed a commit to lukaszewczak/node that referenced this pull request Sep 23, 2017
@bnoordhuis @lukaszewczak
src: return references from getters, not copies
dddd510 
PR-URL: nodejs#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
lukaszewczak pushed a commit to lukaszewczak/node that referenced this pull request Sep 23, 2017
@bnoordhuis @lukaszewczak
src: constify PerformanceEntry data members
8af6ce9 
PR-URL: nodejs#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 23, 2017
@bnoordhuis @addaleax
src: remove unused static variable
2292381 
PR-URL: nodejs/node#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 23, 2017
@bnoordhuis @addaleax
src: handle uv_async_init() failure
03c686b 
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

PR-URL: nodejs/node#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 23, 2017
@bnoordhuis @addaleax
src: return references from getters, not copies
7fd4bcb 
PR-URL: nodejs/node#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 23, 2017
@bnoordhuis @addaleax
src: constify PerformanceEntry data members
c92880e 
PR-URL: nodejs/node#15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

jasnell commented Sep 25, 2017

Copy link
Copy Markdown
Member

This cannot land in v8.x until #15391 does, and I believe #15391 depends on v8 6.1 landing in 8.x (ping @addaleax)

@addaleax

addaleax commented Sep 25, 2017

Copy link
Copy Markdown
Member

and I believe #15391 depends on v8 6.1 landing in 8.x

Not really, I think? It’s easier this way because I think we’d get merge conflicts with V8 6.0, but it should be doable either way.

MylesBorins pushed a commit that referenced this pull request Sep 28, 2017
@bnoordhuis @MylesBorins
src: remove unused static variable
e268289 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2017
@bnoordhuis @MylesBorins
src: handle uv_async_init() failure
ccb0b13 
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2017
@bnoordhuis @MylesBorins
src: return references from getters, not copies
33d83d3 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2017
@bnoordhuis @MylesBorins
src: constify PerformanceEntry data members
663ee47 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@bnoordhuis @MylesBorins
src: remove unused static variable
b785b35 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@bnoordhuis @MylesBorins
src: handle uv_async_init() failure
77103f7 
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@bnoordhuis @MylesBorins
src: return references from getters, not copies
db1c65f 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@bnoordhuis @MylesBorins
src: constify PerformanceEntry data members
f235f09 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@bnoordhuis @MylesBorins
src: remove unused static variable
d202c05 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@bnoordhuis @MylesBorins
src: handle uv_async_init() failure
aded597 
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@bnoordhuis @MylesBorins
src: return references from getters, not copies
e72761a 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@bnoordhuis @MylesBorins
src: constify PerformanceEntry data members
fd1a892 
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins

MylesBorins commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bnoordhuis @BridgeAR @jasnell @addaleax @MylesBorins @cjihrig @tniessen @nodejs-github-bot