{{ message }}
refactor test/sequential/test-fs-watch.js#14534
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
added
fs
Member
Author
Member
Author
|
@nodejs/testing |
3 tasks
cjihrig
approved these changes
Jul 30, 2017
Contributor
There was a problem hiding this comment.
While you're here, can we have something nicer than assert(0)
Member
Author
There was a problem hiding this comment.
Switched to common.mustNotCall(). Thanks.
* add block scoping * rename block-scoped identifiers (e.g., filenameTwo -> filename) * use common.mustCall() instead of exit handler * use common.mustNotCall() as appropriate * order modules per test writing guide
Member
Author
Member
Author
|
Landed in 8c2cac6 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 1, 2017
* add block scoping * rename block-scoped identifiers (e.g., filenameTwo -> filename) * use common.mustCall() instead of exit handler * use common.mustNotCall() as appropriate * order modules per test writing guide PR-URL: nodejs#14534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it just add the |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 1, 2017
* add block scoping * rename block-scoped identifiers (e.g., filenameTwo -> filename) * use common.mustCall() instead of exit handler * use common.mustNotCall() as appropriate * order modules per test writing guide PR-URL: nodejs#14534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
I think this (and I'd guess a lot of other things) will land cleanly if #14162 is backported first. Still, I want this to land so I'm going to go backport it right now... |
4 tasks
Member
Author
|
Backported in #14575 |
addaleax
pushed a commit
that referenced
this pull request
Aug 1, 2017
* add block scoping * rename block-scoped identifiers (e.g., filenameTwo -> filename) * use common.mustCall() instead of exit handler * use common.mustNotCall() as appropriate * order modules per test writing guide Backport-PR-URL: #14575 Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #14534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs