{{ message }}
test: remove --no-crankshaft#14531
Closed
MylesBorins wants to merge 1 commit into
Closed
Conversation
The option `--no-crankshaft` is no longer available as of V8 6.0
Contributor
Author
Contributor
|
@MylesBorins this properly works without #14004? |
evanlucas
approved these changes
Jul 28, 2017
Contributor
Author
|
@Fishrock123 the original change works properly on master afaict. I rebased #14004 and now we have the failures |
Contributor
|
@Fishrock123 V8 5.9 (currently in master) already has crankshaft disabled by default. This PR LGTM. |
Trott
approved these changes
Jul 28, 2017
Trott
left a comment
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. Seems like a sufficiently small change that fast-tracking is 👌 by me.
Contributor
|
odd, the CI never updated this even though it completed successfully... |
Fishrock123
approved these changes
Jul 28, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 28, 2017
The option `--no-crankshaft` is no longer available as of V8 6.0 PR-URL: nodejs#14531 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Member
|
Landed in 7128e3c |
Member
addaleax
pushed a commit
that referenced
this pull request
Jul 29, 2017
The option `--no-crankshaft` is no longer available as of V8 6.0 PR-URL: #14531 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option
--no-crankshaftis no longer available as of V8 6.0This needs to land to get the test suite working for #14004