make node-gyp work with io.js-nightly versions by jakeburden · Pull Request #1424 · nodejs/node · GitHub
Skip to content

make node-gyp work with io.js-nightly versions#1424

Closed
jakeburden wants to merge 2 commits into
nodejs:v1.xfrom
jakeburden:node-gyp-nightly-support
Closed

make node-gyp work with io.js-nightly versions#1424
jakeburden wants to merge 2 commits into
nodejs:v1.xfrom
jakeburden:node-gyp-nightly-support

Conversation

@jakeburden

Copy link
Copy Markdown

Check process.version for 'nightly'. If using io.js nightly, the disUrl is changed accordingly, allowing for the correct tarball url path to be created.

This allows node-gyp to work in io.js nightly versions.

@mscdex mscdex added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 14, 2015
@rvagg

rvagg commented Apr 14, 2015

Copy link
Copy Markdown
Member

@piscisaureus

Copy link
Copy Markdown
Contributor

we really need to get the longer-term solution to node-gyp in there

Shipping the headers with the installer is something we should do also.
And indeed, I think we (as in io.js) should take control of node-gyp, and provide an end-to-end solution that doesn't only provide a build infrastructure but also the API (nan?) and possibly even the compiler itself.

@rvagg

rvagg commented Apr 16, 2015

Copy link
Copy Markdown
Member

@TooTallNate would you be interested in "donating" node-gyp to the iojs org like I've done with NAN? it would mean more eyes and hands on the code to improve it over time, including the long desired ability to use locally installed headers rather than download if they are available.

@Fishrock123

Copy link
Copy Markdown
Contributor

Closing in favor of #493

@jbergstroem

Copy link
Copy Markdown
Member

@jbergstroem jbergstroem closed this Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants