{{ message }}
make node-gyp work with io.js-nightly versions#1424
Closed
jakeburden wants to merge 2 commits into
Closed
Conversation
Member
Contributor
Shipping the headers with the installer is something we should do also. |
Member
|
@TooTallNate would you be interested in "donating" node-gyp to the iojs org like I've done with NAN? it would mean more eyes and hands on the code to improve it over time, including the long desired ability to use locally installed headers rather than download if they are available. |
Contributor
|
Closing in favor of #493 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Check process.version for 'nightly'. If using io.js nightly, the disUrl is changed accordingly, allowing for the correct tarball url path to be created.
This allows node-gyp to work in io.js nightly versions.