{{ message }}
Repository navigation
Commit f2972bf
test: accept ENOTEMPTY from libc++ in test-fs-rm
fs.rmSync() is implemented with std::filesystem::remove_all(). When a
read-only directory has a child, libc++ before LLVM 23 drops the
child's EACCES and reports the ENOTEMPTY it then gets for the parent
instead. The test pinned that behavior to macOS, but it depends on the
C++ standard library rather than on the OS: a Linux build against
libc++ fails the test when run as non-root, and macOS will start
reporting EACCES once it ships the fixed libc++. Accept either code
for that case on all POSIX platforms.
Refs: llvm/llvm-project#197104
Refs: #57103
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #66065
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>1 parent 63469ca commit f2972bf
1 file changed
Lines changed: 3 additions & 4 deletions
0 commit comments