src: fix source list on V8 7.4 by mmarchini · Pull Request #316 · nodejs/llnode · GitHub
Skip to content

src: fix source list on V8 7.4 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 1 commit into from
Closed

src: fix source list on V8 7.4 #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/llnode.cc
View file
Open in desktop
10 changes: 10 additions & 0 deletions src/llv8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,16 @@ Smi JSFrame::FromFrameMarker(Value value) const {
return Smi(value);
}


bool JSFrame::MightBeV8Frame(lldb::SBFrame& frame) {
// TODO(mmarchini): There might be a better way to check for V8 builtins
// embedded in the binary.
auto c_function_name = frame.GetFunctionName();
std::string function_name(c_function_name != nullptr ? c_function_name : "");

return !frame.GetSymbol().IsValid() || function_name.find("Builtins_") == 0;
}

std::string JSFunction::GetDebugLine(std::string args, Error& err) {
SharedFunctionInfo info = Info(err);
if (err.Fail()) return std::string();
Expand Down
2 changes: 2 additions & 0 deletions src/llv8.h
View file
Open in desktop