build: drop v6.x support by mmarchini · Pull Request #292 · nodejs/llnode · GitHub
Skip to content

build: drop v6.x support#292

Closed
mmarchini wants to merge 1 commit into
nodejs:masterfrom
mmarchini:drop-6-support
Closed

build: drop v6.x support#292
mmarchini wants to merge 1 commit into
nodejs:masterfrom
mmarchini:drop-6-support

Conversation

@mmarchini

Copy link
Copy Markdown
Contributor

Node.js v6.x is EOL. Keeping it around makes it more dificult to support
new versions, so dropping support seems reasonable. This is
semver-major.

Node.js v6.x is EOL. Keeping it around makes it more dificult to support
new versions, so dropping support seems reasonable. This is
semver-major.
@codecov-io

codecov-io commented Sep 18, 2019

Copy link
Copy Markdown

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to dropping support for EOL release lines.

@mmarchini

Copy link
Copy Markdown
Contributor Author

cc @nodejs/llnode @nodejs/diagnostics @nodejs/post-mortem for visibility

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmarchini added a commit that referenced this pull request Sep 20, 2019
Node.js v6.x is EOL. Keeping it around makes it more dificult to support
new versions, so dropping support seems reasonable. This is
semver-major.

PR-URL: #292
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@mmarchini

Copy link
Copy Markdown
Contributor Author

Landed in e1a74b0

@mmarchini mmarchini closed this Sep 20, 2019
@codecov-commenter

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants