src: fix JSError inspection with stringified stack by mmarchini · Pull Request #291 · nodejs/llnode · GitHub
Skip to content

src: fix JSError inspection with stringified stack #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 1 commit into from
Closed

src: fix JSError inspection with stringified stack #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/llv8.cc
View file
Open in desktop
36 changes: 20 additions & 16 deletions src/printer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,27 +526,31 @@ std::string Printer::Stringify(v8::JSError js_error, Error& err) {
if (options_.detailed) {
output << StringifyJSObjectFields(js_error, err);

v8::StackTrace stack_trace = js_error.GetStackTrace(err);
if (js_error.HasStackTrace(err)) {
v8::StackTrace stack_trace = js_error.GetStackTrace(err);

std::stringstream error_stack;
error_stack << std::endl
<< rang::fg::red << " error stack" << rang::fg::reset << " {"
<< std::endl;
std::stringstream error_stack;
error_stack << std::endl
<< rang::fg::red << " error stack" << rang::fg::reset << " {"
<< std::endl;

Printer printer(llv8_);
for (v8::StackFrame frame : stack_trace) {
v8::JSFunction js_function = frame.GetFunction(err);
if (err.Fail()) {
error_stack << rang::fg::gray << " <unknown>" << std::endl;
continue;

Printer printer(llv8_);
for (v8::StackFrame frame : stack_trace) {
v8::JSFunction js_function = frame.GetFunction(err);
if (err.Fail()) {
error_stack << rang::fg::gray << " <unknown>" << std::endl;
continue;
}

error_stack << " "
<< printer.Stringify<v8::HeapObject>(js_function, err)
<< std::endl;
}

error_stack << " "
<< printer.Stringify<v8::HeapObject>(js_function, err)
<< std::endl;
error_stack << " }";
output << error_stack.str();
}
error_stack << " }";
output << error_stack.str();
}

output << rang::fg::yellow << ">" << rang::fg::reset;
Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/inspect-scenario.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ function closure() {
c.hashmap['error'].code = 'ERR_TEST';
c.hashmap['error'].errno = 1;

c.hashmap['stringifiedError'] = new Error('test');
c.hashmap['stringifiedErrorStack'] = c.hashmap['stringifiedError'].stack;

c.hashmap[0] = null;
c.hashmap[4] = undefined;
c.hashmap[23] = /regexp/;
Expand Down
22 changes: 22 additions & 0 deletions test/plugin/inspect-test.js
View file
Open in desktop