{{ message }}
build: add llhttp-specific prefix to CMake options.#657
Merged
Uzlopak merged 3 commits intoAug 5, 2025
Conversation
BUILD_SHARED_LIBS is now called LLHTTP_BUILD_SHARED_LIBS. BUILD_STATIC_LIBS is now called LLHTTP_BUILD_STATIC_LIBS. CMake options have global scope so there's the risk of conflict otherwise. For example, libcurl has a BUILD_STATIC_LIBS option too. Documentation updates to be discussed. See nodejs#647
Contributor
Author
Contributor
|
Thanks for the PR! |
Contributor
13 tasks
This was referenced Apr 20, 2026
npc1054657282
added a commit
to npc1054657282/xmake-repo
that referenced
this pull request
Apr 20, 2026
fix xmake-io#9802 1. nodejs/llhttp#657 replaced the `BUILD_SHARED_LIBS` and `BUILD_STATIC_LIBS` with `LLHTTP_BUILD_SHARED_LIBS` and `LLHTTP_BUILD_STATIC_LIBS`. 2. Fix double compilation bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

BUILD_SHARED_LIBS is now called LLHTTP_BUILD_SHARED_LIBS.
BUILD_STATIC_LIBS is now called LLHTTP_BUILD_STATIC_LIBS.
CMake options have global scope so there's the risk of conflict otherwise. For example, libcurl has a BUILD_STATIC_LIBS option too.
Documentation updates to be discussed.
See #647