build: add llhttp-specific prefix to CMake options. by tom-seddon · Pull Request #657 · nodejs/llhttp · GitHub
Skip to content

build: add llhttp-specific prefix to CMake options.#657

Merged
Uzlopak merged 3 commits into
nodejs:mainfrom
tom-seddon:tom/issue_647.BUILD_STATIC_LIBS_naming
Aug 5, 2025
Merged

build: add llhttp-specific prefix to CMake options.#657
Uzlopak merged 3 commits into
nodejs:mainfrom
tom-seddon:tom/issue_647.BUILD_STATIC_LIBS_naming

Conversation

@tom-seddon

Copy link
Copy Markdown
Contributor

BUILD_SHARED_LIBS is now called LLHTTP_BUILD_SHARED_LIBS.

BUILD_STATIC_LIBS is now called LLHTTP_BUILD_STATIC_LIBS.

CMake options have global scope so there's the risk of conflict otherwise. For example, libcurl has a BUILD_STATIC_LIBS option too.

Documentation updates to be discussed.

See #647

BUILD_SHARED_LIBS is now called LLHTTP_BUILD_SHARED_LIBS.

BUILD_STATIC_LIBS is now called LLHTTP_BUILD_STATIC_LIBS.

CMake options have global scope so there's the risk of conflict
otherwise. For example, libcurl has a BUILD_STATIC_LIBS option too.

Documentation updates to be discussed.

See nodejs#647
@tom-seddon

tom-seddon commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

@ShogunPanda

Copy link
Copy Markdown
Contributor

Thanks for the PR!
I would say put the latest 9.x.y version, but eventually put a comment that says that prior to version 9.2.1 included the variables should not use the LLHTTP_ prefix.

@Uzlopak

Uzlopak commented Jun 1, 2025

Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak merged commit b671ac1 into nodejs:main Aug 5, 2025
7 checks passed
npc1054657282 added a commit to npc1054657282/xmake-repo that referenced this pull request Apr 20, 2026
fix xmake-io#9802
1. nodejs/llhttp#657 replaced the `BUILD_SHARED_LIBS` and
`BUILD_STATIC_LIBS` with `LLHTTP_BUILD_SHARED_LIBS` and
`LLHTTP_BUILD_STATIC_LIBS`.
2. Fix double compilation bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants