{{ message }}
Added doc, benchmark and deps/X node core PR labels#32
Merged
Conversation
4 tasks
Member
Author
Contributor
|
post LGTM! ;) |
Member
Author
|
@williamkapke thanks! 😄 |
| // order of entries in this map *does* matter for the resolved labels | ||
| const subSystemLabelsMap = { | ||
| // don't want to label it a c++ update when we're "only" bumping the Node.js version | ||
| 'c++': /^src\/(?!node_version\.h)/, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
belated LGTM. I'll try to find time to tackle some of the more complex ones soon |
Contributor
|
nodejs/node#6432 Seems to have been labeled as |
Contributor
|
Hmm, seems like this doesn't only label |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the current node core auto PR labelling functionality by supporting these extra labels:
docfor exclusivedoc/*changesbenchmarkfor exclusivebenchmark/*changesv8,libuv,openssletc when having changes indeps/X/*Also ignores changes to
src/node_version.hto avoid labelling that asc++as mentioned in #31 (comment).@jbergstroem @mscdex @Fishrock123 does these labels sound reasonable to you?
Refs #31, nodejs/node#6247