feat: replace Bash update with full JS build by nschonni · Pull Request #2659 · nodejs/docker-node · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions .github/workflows/automatic-updates.yml
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ After the end of Debian LTS support, the corresponding Debian release is dropped
### Image Creation Automation

- Every 15 minutes, the [workflow](https://github.com/nodejs/docker-node/blob/main/.github/workflows/automatic-updates.yml) within the [nodejs/docker-node](https://github.com/nodejs/docker-node) repo [checks](https://github.com/nodejs/docker-node/blob/main/build-automation.mjs) for new versions of Node.js [published to the website's `index.json` file](https://nodejs.org/download/release/index.json).
- If found, the [update script](https://github.com/nodejs/docker-node/blob/main/update.sh) runs
- If found, the [update script](https://github.com/nodejs/docker-node/blob/main/build-automation.mjs) runs
- The workflow opens a pull request either automatically via [nodejs-github-bot](https://github.com/nodejs-github-bot) or in some cases manually, such as when there is a new major release.
- Another [workflow](https://github.com/nodejs/docker-node/blob/main/.github/workflows/official-pr.yml) detects the merger of these pull requests and opens a pull request to [docker-library/official-images](https://github.com/docker-library/official-images).
- The official images are built and published according to [docker's process](https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what), resulting in the new images being available on [Docker Hub](https://hub.docker.com/_/node).
Expand All @@ -167,7 +167,7 @@ and your suggestion to resolve it.
To set up a version update pull request, see the [Pull Requests](#pull-requests) section above and follow these instructions:

1. Create a `version-update` branch
1. Run `./update.sh`. You can see additional options by using the built-in help documentation with `./update.sh -h`. This script will automatically update the appropriate files with the latest versions and checksums.
1. Run `npm run build`. This script will automatically update the appropriate files with the latest versions.
1. Commit the modified files to the `version-update` branch and push the branch to your fork.
1. Create a pull request.

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-alpine.template
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ RUN addgroup -g 1000 node \
curl \
&& ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
&& case "${alpineArch##*-}" in \
"${ALPINE_ARCH[@]}"
"${SUPPORTED_ARCH[@]}"
esac \
# use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150
&& export GNUPGHOME="$(mktemp -d)" \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-debian.template
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ENV NODE_VERSION=0.0.0

RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
"${DEB_ARCH[@]}"
"${SUPPORTED_ARCH[@]}"
esac \
# use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150
&& export GNUPGHOME="$(mktemp -d)" \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-slim.template
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ENV NODE_VERSION=0.0.0

RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
"${DEB_ARCH[@]}"
"${SUPPORTED_ARCH[@]}"
esac \
&& set -ex \
&& apt-get update && apt-get install -y ca-certificates curl wget gnupg dirmngr xz-utils libatomic1 --no-install-recommends \
Expand Down
7 changes: 0 additions & 7 deletions architectures

This file was deleted.

237 changes: 140 additions & 97 deletions build-automation.mjs
4 changes: 0 additions & 4 deletions config

This file was deleted.

Loading
Loading