ci: fix markdown-link-check by MikeMcC399 · Pull Request #2296 · nodejs/docker-node · GitHub
Skip to content

ci: fix markdown-link-check#2296

Merged
mcollina merged 3 commits intonodejs:mainfrom
MikeMcC399:fix/markdown-link-checks
Oct 18, 2025
Merged

ci: fix markdown-link-check#2296
mcollina merged 3 commits intonodejs:mainfrom
MikeMcC399:fix/markdown-link-checks

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 commented Oct 17, 2025

Description

In .github/workflows/markdown-link-check.yml

In markdown_link_check_config.json

Motivation and Context

The workflow .github/workflows/markdown-link-check.yml is sporadically failing with HTTP 403 Forbidden errors for:

See workflow logs

The httpHeaders config section is no longer needed. Link checking to https://docs.github.com works without it.

See also the community post https://github.com/orgs/community/discussions/174098 for background on https://www.npmjs.com/ heightened security.

Testing Details

On Ubuntu 24.04.3 LTS, with Node.js 22.20.0 LTS

npm install markdown-link-check@3.14.1 -g
find . -name "*.md"  ! -path "./.git/*" | xargs -n 1 markdown-link-check -c markdown_link_check_config.json

No dead links should be reported.

Also tested in GitHub Actions https://github.com/MikeMcC399/docker-node/actions/workflows/markdown-link-check.yml

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@MikeMcC399
Copy link
Copy Markdown
Contributor Author

MikeMcC399 commented Oct 17, 2025 •
edited
Loading

This was referenced Oct 17, 2025
Merged
Open

This comment was marked as spam.

Sign in to view

mcollina
mcollina approved these changes Oct 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nschonni nschonni mentioned this pull request Oct 18, 2025
Closed
12 tasks
@MikeMcC399
Copy link
Copy Markdown
Contributor Author

MikeMcC399 commented Oct 18, 2025

mcollina
mcollina approved these changes Oct 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9d83122 into nodejs:main Oct 18, 2025
3 checks passed
@MikeMcC399 MikeMcC399 deleted the fix/markdown-link-checks branch October 18, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcC399 @mcollina