lib: add cli to valid subsystems by codebytere · Pull Request #79 · nodejs/core-validate-commit · GitHub
Skip to content

lib: add cli to valid subsystems#79

Merged
Trott merged 2 commits into
nodejs:masterfrom
codebytere:add-cli-subsystem
Oct 30, 2019
Merged

lib: add cli to valid subsystems#79
Trott merged 2 commits into
nodejs:masterfrom
codebytere:add-cli-subsystem

Conversation

@codebytere

Copy link
Copy Markdown
Member

Refs nodejs/node#30094.

Adds cli to the list of valid subsystems.

cc @addaleax

@codecov

codecov Bot commented Oct 24, 2019

Copy link
Copy Markdown

Comment thread lib/rules/subsystem.js Outdated
@codebytere

Copy link
Copy Markdown
Member Author

Who has merge access for this repo? I'm happy to land but i don't think i can 🤔

@Trott Trott merged commit 1fc0d9c into nodejs:master Oct 30, 2019
@codebytere codebytere deleted the add-cli-subsystem branch October 30, 2019 20:58
@Trott

Trott commented Oct 30, 2019

Copy link
Copy Markdown
Member

Merged it but I can't publish to npm. (Anyone want to add me to ~nodejs-foundation on npm?)

@richardlau

Copy link
Copy Markdown
Member

Published in v3.12.1.

@richardlau

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants