aix: install rust by abmusse · Pull Request #4273 · nodejs/build · GitHub
Skip to content

aix: install rust#4273

Merged
richardlau merged 5 commits into
nodejs:mainfrom
abmusse:rust-aix
Apr 16, 2026
Merged

aix: install rust#4273
richardlau merged 5 commits into
nodejs:mainfrom
abmusse:rust-aix

Conversation

@abmusse

@abmusse abmusse commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Add rust, cargo, and rustfmt to the list of packages to install.

@abmusse abmusse requested review from richardlau and sxa March 13, 2026 21:49
@richardlau

Copy link
Copy Markdown
Member

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm sure you'd agree, none of these options are good :'(

I guess that since the version is hardcoded to 1.88 we could legitimately use any of those. I might lean towards the symlinks (mostly to make any manual building/debugging on the machine easier) although I do wonder if there was a good reason the package maintainer decided to keep it isolated like this and not include a symlink.

@abmusse

abmusse commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

As I'm sure you'd agree, none of these options are good :'(

I guess that since the version is hardcoded to 1.88 we could legitimately use any of those. I might lean towards the symlinks (mostly to make any manual building/debugging on the machine easier) although I do wonder if there was a good reason the package maintainer decided to keep it isolated like this and not include a symlink.

I'm ok with creating the symlinks, just wondering where would best spot to do so in the playbooks? I guess I could do that in select-compiler.sh or the AIX Jenkins start script.

@richardlau

richardlau commented Apr 13, 2026

Copy link
Copy Markdown
Member

As I'm sure you'd agree, none of these options are good :'(
I guess that since the version is hardcoded to 1.88 we could legitimately use any of those. I might lean towards the symlinks (mostly to make any manual building/debugging on the machine easier) although I do wonder if there was a good reason the package maintainer decided to keep it isolated like this and not include a symlink.

I'm ok with creating the symlinks, just wondering where would best spot to do so in the playbooks? I guess I could do that in select-compiler.sh or the AIX Jenkins start script.

Don't create symlinks in select-compiler.sh -- We only want to set env variables in there (e.g. setting PATH). If you opt for symlinks, create a new aix.yml in ansible/roles/baselayout/tasks/partials/postinstall which gets run after the package installs by

- name: run os-specific steps after package install
include_tasks: "{{ post_include }}"
loop_control:
loop_var: post_include
with_first_found:
- files:
- "{{ role_path }}/tasks/partials/postinstall/{{ os }}.yml"
- "{{ role_path }}/tasks/partials/postinstall/{{ os|stripversion }}.yml"
skip: true
.

@targos

targos commented Apr 16, 2026

Copy link
Copy Markdown
Member

Can we merge this and #4286 ?

@richardlau richardlau merged commit 637da10 into nodejs:main Apr 16, 2026
1 check passed
@richardlau

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants