redirect for Windows Environment wiki page by joaocgreis · Pull Request #286 · nodejs/build · GitHub
Skip to content

redirect for Windows Environment wiki page#286

Merged
joaocgreis merged 1 commit into
nodejs:masterfrom
JaneaSystems:joaocgreis-FCN-windows-installer-link
Jan 6, 2016
Merged

redirect for Windows Environment wiki page#286
joaocgreis merged 1 commit into
nodejs:masterfrom
JaneaSystems:joaocgreis-FCN-windows-installer-link

Conversation

@joaocgreis

Copy link
Copy Markdown
Member

This is necessary to land nodejs/node#4111

@rvagg is this the correct way to add the redirect?

@rvagg

rvagg commented Dec 24, 2015

Copy link
Copy Markdown
Member

@jbergstroem

Copy link
Copy Markdown
Member

+1 to https only. Redirects like these will stay in a config forever; the less rules the better

@joaocgreis joaocgreis force-pushed the joaocgreis-FCN-windows-installer-link branch from c55dbdc to 0f89f0b Compare December 24, 2015 14:09
@joaocgreis

Copy link
Copy Markdown
Member Author

Thanks, updated

@orangemocha

Copy link
Copy Markdown

LGTM

Redirect pointing to the wiki page, to be used by the Windows installer.

Ref: nodejs/node#4111

PR-URL: nodejs#286
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
@joaocgreis joaocgreis force-pushed the joaocgreis-FCN-windows-installer-link branch from 0f89f0b to 9079242 Compare January 6, 2016 09:24
@joaocgreis joaocgreis merged commit 9079242 into nodejs:master Jan 6, 2016
@joaocgreis

Copy link
Copy Markdown
Member Author

@rvagg what more needs to be done here to update the server config?

@rvagg

rvagg commented Jan 12, 2016

Copy link
Copy Markdown
Member

Sorry! Someone with access to the web server just needed to drop this in /etc/nginx/sites-available/ and reload nginx. I've done that now, https://nodejs.org/windows-environment is active.

@joaocgreis

Copy link
Copy Markdown
Member Author

Thanks!

@jbergstroem

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants