{{ message }}
build against shared library for libcurl#1195
Merged
johnhaley81 merged 5 commits intoFeb 6, 2017
Merged
Conversation
First pass of proxyOpts normalization
Member
Author
implausible
force-pushed
the
feature/enable-curl-support
branch
from
56ea77f to
308f0ae
Compare
Member
Author
|
Getting proxy options fully tested is going to be very difficult. For now, this passes all of the test cases, and does not worsen NodeGit. Had a discussion with @johnhaley81, we'll come back for tests on this when we have a good framework for an on-the-fly forward proxy. |
Collaborator
|
Probably a custom proxy through express or something would be easiest. |
Collaborator
|
Looking at this now. |
Collaborator
|
Tested this in a proxied environment and confirmed it worked. Thanks @implausible. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get proxy support into NodeGit, we will need to get libgit configured to use libcurl. To start, we will just try to build nodegit against libcurl using the -lcurl flag.
We will also expose and handle proxy_options, the goal of this PR is to get proxy support in full across all systems.
This should address #489