{{ message }}
Leave Monaco theme commented out by default#3704
Merged
Merged
Conversation
Steve-Mcl
approved these changes
Jun 26, 2022
Steve-Mcl
left a comment
Steve-Mcl
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
As far as I am concerned, this is a safe and backwards compatible way to permit a theme to specify the code editor theme without user having to modify settings.js
Member
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Leave Monaco theme commented out by default.
If it’s commented out and a theme doesn’t have it defined, it defaults to that same value anyway.
And themes that define it won't have to request the user to comment it out in settings.js to have their customizations loaded.
Checklist
gruntto verify the unit tests pass