Set monaco as default code editor as of v3.x by Steve-Mcl · Pull Request #3543 · node-red/node-red · GitHub
Skip to content

Set monaco as default code editor as of v3.x#3543

Merged
knolleary merged 1 commit into
node-red:devfrom
Steve-Mcl:monaco-default
Apr 25, 2022
Merged

Set monaco as default code editor as of v3.x#3543
knolleary merged 1 commit into
node-red:devfrom
Steve-Mcl:monaco-default

Conversation

@Steve-Mcl

Copy link
Copy Markdown
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Set monaco as the default code editor from node-red V3

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl requested review from dceejay and knolleary April 23, 2022 09:05
@Steve-Mcl Steve-Mcl added this to the 3.0 milestone Apr 23, 2022
@coveralls

Copy link
Copy Markdown

@dceejay

dceejay commented Apr 23, 2022

Copy link
Copy Markdown
Member

@knolleary knolleary left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knolleary knolleary merged commit 10a45ec into node-red:dev Apr 25, 2022
@Steve-Mcl Steve-Mcl deleted the monaco-default branch April 25, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

4 participants