feat: refactor with typescript by liuhanqu · Pull Request #117 · node-modules/ready-callback · GitHub
Skip to content

feat: refactor with typescript#117

Merged
fengmk2 merged 2 commits into
node-modules:masterfrom
liuhanqu:feat/ts
Oct 11, 2023
Merged

feat: refactor with typescript#117
fengmk2 merged 2 commits into
node-modules:masterfrom
liuhanqu:feat/ts

Conversation

@liuhanqu

@liuhanqu liuhanqu commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: Drop Node.js < 16 support

closes #116

@socket-security

socket-security Bot commented Oct 10, 2023

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 10, 2023

Copy link
Copy Markdown

Codecov Report

Merging #117 (cd2f99e) into master (f5bfa41) will increase coverage by 1.36%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #117      +/-   ##
===========================================
+ Coverage   98.63%   100.00%   +1.36%     
===========================================
  Files           1         1              
  Lines         146       147       +1     
  Branches       28        29       +1     
===========================================
+ Hits          144       147       +3     
+ Misses          2         0       -2     
Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread tsconfig.json Outdated
@fengmk2 fengmk2 self-assigned this Oct 10, 2023
Comment thread src/index.ts Outdated
@fengmk2 fengmk2 merged commit 7193ec1 into node-modules:master Oct 11, 2023
@fengmk2

fengmk2 commented Oct 11, 2023

Copy link
Copy Markdown
Member

fengmk2 pushed a commit that referenced this pull request Oct 11, 2023
[skip ci]

## [4.0.0](v3.0.0...v4.0.0) (2023-10-11)

### ⚠ BREAKING CHANGES

* Drop Node.js < 16 support

closes #116

part of eggjs/egg#5257

### Features

* refactor with typescript to support esm and cjs both ([#117](#117)) ([7193ec1](7193ec1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

need to refactor with typescript ?

2 participants