Improve keep extension by GrosSacASac · Pull Request #857 · node-formidable/formidable · GitHub
Skip to content

Improve keep extension#857

Merged
GrosSacASac merged 11 commits into
masterfrom
improve-keep-extension
May 19, 2022
Merged

Improve keep extension#857
GrosSacASac merged 11 commits into
masterfrom
improve-keep-extension

Conversation

@GrosSacASac

Copy link
Copy Markdown
Contributor

fixes #856

@GrosSacASac GrosSacASac merged commit 81dd350 into master May 19, 2022
@GrosSacASac GrosSacASac deleted the improve-keep-extension branch May 19, 2022 10:13
Comment thread src/Formidable.js

@tunnckoCore tunnckoCore Jun 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember pretty clearly there was some reason for that, some report or feature or issue.. but i don't remember the reason haha, so we can switch back to just getting the thing after the last dot with Node's builtin and all the drama goes to the trash.

Comment thread examples/with-http.js

@tunnckoCore tunnckoCore Jun 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we better use filenamify instead.

filenamify(name, { replacement: '-' })

there will not be needed for ext, because we can just return path.extname, as per the other comments.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, that's from the examples dir, lol

@tunnckoCore tunnckoCore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments

@GrosSacASac

@hasle4real hasle4real left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulnerability CVE-2022-29622 is reported by Whitesource

3 participants