@zhaoda Can I suggest you add node 8 and 9 to .travis.yml (here) and maybe drop v0.10 and v0.12? They can't be tested anymore because mocha no longer supports them.

Thanks! I'll take care of you suggestions @bnoordhuis

@TooTallNate are you going to publish a new version with the Node.js 9 support?

I had a real quick look and the crashes appear to be cif->arg_types and cif->rtype pointers pointing to invalid memory locations - sometimes 0, sometimes a random address.

From a quick reading of the source:

1. the test creates a ffi.Callback object
2. then drops the reference to said object
3. calls gc() to reclaim the cif memory
4. memory is written over while still in use by libffi

If it works with older node.js versions, that's probably purely accidental.

Can you* release v2.2.1 of ffi with this PR included? (*edit: dear maintainers)

811ad02

This pull request seems to fix my build issue on Windows 7 + NWJS 0.28.1 (32-bit) + Visual Studio 2015.

Initial testing with some 3rd party DLLs seems to work.

Folks, it'll really help if the above mentioned fix is released. Thanks.

@TooTallNate Can you please release this? We've been waiting for a long time now. We'll also need support for node 10.x, I'll create another issue for that.

@TooTallNate Can you please release this? We've been waiting for a long time now. We'll also need support for node 10.x, I'll create another issue for that.

A new release with this patch would be very helpful, because building native modules for Electron 3.x.x is currently broken!

hi @berkon I encountered the same issue with my electron project. Do you happen to know of any workaround before this patch is released? Thank you

@belloyang, yes there has obviously already been a patch which fixes the issue. You could also do the modifications by yourself quite easily:

84e1817

Its not clear to me why they don't release a new version. The changes are really minor, but would help a lot.