Adding support for mjs files by skitscha · Pull Request #786 · node-config/node-config · GitHub
Skip to content

Adding support for mjs files#786

Closed
skitscha wants to merge 1 commit into
node-config:masterfrom
skitscha:master
Closed

Adding support for mjs files#786
skitscha wants to merge 1 commit into
node-config:masterfrom
skitscha:master

Conversation

@skitscha

Copy link
Copy Markdown

Updating parsers to support mjs configuration files.

@skitscha

skitscha commented Feb 27, 2025

Copy link
Copy Markdown
Author

@skitscha

skitscha commented Mar 6, 2025

Copy link
Copy Markdown
Author

@lorenwest Would you be able to take a look at this?

@jdmarshall

Copy link
Copy Markdown
Collaborator

Can you add a test for this, in the same style as the other tests for the parser?

@jdmarshall

Copy link
Copy Markdown
Collaborator

@markstos is there a reason this couldn’t land in 3.0?

@markstos

Copy link
Copy Markdown
Collaborator

It's true that this could go into a 3.0 release. It is not a breaking change.

@markstos markstos removed the 4.0 label Apr 17, 2025
@jdmarshall

Copy link
Copy Markdown
Collaborator

@jdmarshall jdmarshall closed this Apr 17, 2025
@jdmarshall jdmarshall mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants