{{ message }}
Resolve vulnerabilities, update to node 10 or greater.#697
Open
robhybrid wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request resolves several vulnerabilities, including a severe vulnerability. A similar PR is open, but has failing builds.
#695
This one is more comprehensive. The minimum version of Node will need to be updated from 4 to 10 to support the latest version of node-forge. The automated builds need to be updated because tests using Node version 6 and 8 will fail.
These libraries can probably be forked to support legacy node versions, but I don't consider it worth the effort, unless legacy support is absolutely necessary. Please let me know if you decide not to update to the builds to new versions.