{{ message }}
Repository navigation
perf: Group NameResolver::enterNode() checks by node category - #1168
Merged
Merged
Conversation
Contributor
Author
|
Ready to merge 👍 |
staabm
reviewed
Sep 26, 2026
nikic
reviewed
Sep 26, 2026
nikic
left a comment
nikic
left a comment
Owner
There was a problem hiding this comment.
I don't think we rely on subclassing in this code, so I think an even more efficient way would be to do a switch over $node->getType()? That would dispatch in a single check instead of chain.
Contributor
Author
|
@nikic ok, updated to use |
nikic
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameResolver::enterNode()ran every node through a single chain of ~30instanceofchecksThis PR checks
Stmt/Exprfirst and hands off toresolveStmt()/resolveExpr(). The branch bodies are unchanged. Nodes that are neitherStmtnorExpr(~37% of nodes) now exit after 3 checks.Tested on php-parser vendor, laravel framework, it shows faster: