{{ message }}
[볼링 점수판] 1단계 - 질문 삭제하기 기능 리팩토링#807
Merged
Merged
Conversation
1단계 - 질문 삭제하기 기능 리팩토링 - Answers 일급컬렉션 구현 - Answer 객체 삭제 및 삭제 히스토리 객체 변환 메서드 추가 - Question 객체 삭제 및 삭제 히스토리 객체 변환 메서드 추가 - Answer, Question 단위 테스트 코드 작성
ydh6226
approved these changes
May 18, 2022
ydh6226
left a comment
ydh6226
left a comment
There was a problem hiding this comment.
안녕하세요 정재님
볼링 미션을 함께 하게된 양동혁입니다 :)
미션 중 궁금하신 점이 있다면 편하게 DM이나 코멘트로 질문남겨주세요 🔥
1단계 미션 잘 진행해주셔서 바로 머지하겠습니다.
몇 가지 코멘트 남겨드렸으니 확인해보시고
다음 단계에서 같이 반영부탁드려요!
| public Question setContents(String contents) { | ||
| this.contents = contents; | ||
| return this; | ||
| private void validateDeleteQuestion(User loginUser) { |
There was a problem hiding this comment.
개인적으로 구체적으로 어떤 검증을 하는지 네이밍으로 표현하면 좋을 것 같아요 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요, 새로운 리뷰어님!
[볼링 점수판] 1단계 - 질문 삭제하기 기능 리팩토링 완료하여 PR드립니다!
리뷰 잘 부탁드릴게요!! :)
감사합니다!