{{ message }}
Fix auth_app for modern Taiga versions (#227)#229
Open
meck-gd wants to merge 1 commit into
Open
Conversation
meck-gd
force-pushed
the
bugfix/227-fix-app-auth
branch
from
8b25288 to
5a4f5a8
Compare
Member
|
@heck-gd Thanks for this! I'll ping @yakky to have a look at this as soon as possibile, I added a small comment because I'm not entirely sure about what should |
protoroto
reviewed
Sep 4, 2025
protoroto
reviewed
Sep 4, 2025
Author
yakky
approved these changes
Oct 22, 2025
yakky
left a comment
yakky
left a comment
Member
There was a problem hiding this comment.
Due to the incompatible signature of auth_app we should release this with a major version bump and documenting the breaking change in the documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
auth_app()to (only) work with Taiga 3.1.0+ (released in 2016).auth()- rather, it only works once per token because the Taiga backend invalidates theauth_codeduring the request. From what I can tell, applications are supposed to store and re-use the token. It doesn't have an expiration, unlike Bearer tokens.References
Fixes #227
Due to removal of dependency, also fixes #189
Checklist
inv lintchangesfile included (see docs)