Repository navigation
Conversation
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks! I left one comment on the doc
There was a problem hiding this comment.
code change looks good to me! but this section feel like written for ourselves, most of our users will use a released checkpoint with scheduler and sample_sigma already configured. so I think
(1) IMO we don't have to talk about how to config the pipeline and scheduler for the trained checkpoint, but it is ok to keep if you prefer
(2) for sample_sigma and sigma let's keep them simple: sample_simga is for the pipeline authors to config a default sigmas and user who wants to experiment different sigmas at run time should always use the sigmas
|
Thanks, @yiyixuxu! I simplified the docs to focus on users loading a preconfigured checkpoint and using |
ed0e197 to
8038ea9
Compare
| ) | ||
| ``` | ||
|
|
||
| ## Sampling sigmas |
There was a problem hiding this comment.
Should we also not talk about which checkpoint might need this kind of configuration to work with? Otherwise, it feels confusing.
There was a problem hiding this comment.
I think we should also clarify which checkpoint id should this be used with?

What does this PR do?
Accelerated QwenImage21 checkpoints need a fixed sampling sigma schedule that loads with the model. This PR adds
sample_sigmasto the QwenImage21 pipeline config (model_index.json) and passes the selected schedule to the scheduler through its existingsigmasargument.Model authors configure the default
sample_sigmas; users can experiment with an explicit call-timesigmasoverride. The selected grid determines the step count. When neither grid is supplied, the existingnum_inference_stepsbehavior is preserved. The scheduler implementation is unchanged, and explicit grids still undergo its configured processing.This incorporates the pipeline-config approach reviewed in #4 and replaces the scheduler changes proposed in #3. Documentation focuses on loading a preconfigured checkpoint and overriding
sigmasat runtime.Validation
mainatc2798cc7859f258c6cfc5b2460e82b6cac71f235; both commit patches are unchanged by the rebase.Real-model parity was checked for that fixed grid and input. Quality with other grids or four-step sampling has not been evaluated;
num_inference_steps=4alone still uses a configured eight-point grid.