{{ message }}
Repository navigation
Fix inline letter suffix dropped from house number - #154
Merged
Merged
Conversation
DOM_VALUE only matched a bare INT, so an inline literal like 'д. 20А' was parsed as дом '20' plus a stray unparsed 'А' (varchar). Use ADDR_VALUE (which already allows an optional letter suffix) for the house number, so 'д. 20А' yields дом '20А' while the separate 'литера А' form still parses as its own part (fixes natasha#125).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nFixes #125.\n\n
DOM_VALUEonly matched a bare integer, so an inline literal such asд. 20Аwas parsed asдом «20»plus a stray unparsed«А»(surfacing as avarcharpart). This PR makes the house number useADDR_VALUE(which already permits an optional letter suffix), soд. 20Аnow yieldsдом «20А».\n\nThe separate formд. 20, литера Аcontinues to parse asдом «20»+литера «А»(its own part).\n\n## Changes\n\n-natasha/grammars/addr.py:DOM_VALUEnow usesADDR_VALUEinstead of a bareINT.\n-tests/test_addr.py: added a case forг. Москва, ул. Ленина, д. 20А→дом «20А».\n\n## Testing\n\npytest tests/test_addr.py— the new case passes; the 14 pre-existing failures are unrelated (FIAS type-register drift on master, also failing without this change).