{{ message }}
[material-ui][Pagination] Hide ellipses with zero boundary and sibling counts - #49090
Open
lprnmns wants to merge 1 commit into
Open
[material-ui][Pagination] Hide ellipses with zero boundary and sibling counts#49090lprnmns wants to merge 1 commit into
lprnmns wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24749
When both
boundaryCountandsiblingCountare zero, the pagination body currently contains the current page plus start and end ellipses. Those ellipses do not expose any page and make the opt-in compact configuration wider than necessary.This uses the special case proposed in the issue: the body contains only the current page when both counts are zero. Other boundary and sibling count combinations continue through the existing item generation.
Tests:
pnpm test:unit packages/mui-material/src/usePagination/usePagination.test.js --run(32 passed across node and Chromium)pnpm exec eslint packages/mui-material/src/usePagination/usePagination.js packages/mui-material/src/usePagination/usePagination.test.jspnpm exec prettier --check packages/mui-material/src/usePagination/usePagination.js packages/mui-material/src/usePagination/usePagination.test.jspnpm -F @mui/material typescriptpnpm release:build@mui/materialunit run: 10,128 passed; 3 unrelated Select timing tests failed, then passed 6/6 on focused rerun.