You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Okay, I built it and committed all the files: 5df864d. I note a couple of things (possibly worrisome?):
it builds msys-ssl-1.0.0.dll, not msys-ssl-1.0.1.dll as I would have expected... is this so that linked programs will still find it even if they were linked against 1.0.0?
it also builds msys-crypto-1.0.0.dll, does that matter with regards to the crypt issue you mentioned in Upgrade OpenSSH 5.4p1 #221?
despite the fact that we have a 1.2MB msys-crypto-1.0.0.dll and a 300KB msys-ssl-1.0.0.dll file that we did not have before, the openssl.exe binary increased size from ~550KB to 1MB... (It does not matter all that much because we use a MinGW OpenSSL for everything except ssh.exe, but still...)
it builds msys-ssl-1.0.0.dll, not msys-ssl-1.0.1.dll as I would have expected... is this so that linked programs will still find it even if they were linked against 1.0.0?
-s
Remove all symbol table and relocation information from the executable.
I don't add -s as other packages and use default options because CFLAGS environment variable didn't used when compiling. -s looks link option so adding -s to LDFLAGS may work.
Ah, right, you mentioned that, but I missed something: crypt vs crypto. Such confusing naming!
Maybe gcc option -s is different.
I suspected that. Actually, I think it is okay because we might get more detailed information from bug reports that way (AFAIR -s strips out debug information, rendering stack traces pretty useless). OTOH you already opened a PR addressing this...
Thank you so much for all your work, and especially for educating me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build script for openssl 1.0.1h msys.
After this build and rebuilding OpenSSH, OpenSSH can link to openssl 1.0.1h.