{{ message }}
Repository navigation
fix(hermes): decode quoted scalar escapes - #1124
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode doubled apostrophes in single-quoted metadata and escaped quotes/backslashes in double-quoted metadata. Previously valid names such as Don't Panic remained encoded as Don''t Panic in the Hermes catalog. All three actual baseline fixtures fail; fixed metadata fixtures pass. Actual282-agent plugin generation, schema/routing validation and all seven behavior tests pass. This handles the existing supported scalar escapes, not a complete YAML parser.
Final frozen integration a129faa682f16a86604f5d1069445cf8edeadaa0 passes all32 output invariants across301 agents and15 formats, all66 installer checks (two existing XFAIL), whole-roster lint (zero errors,58 existing warnings), originality, focused regressions,26 extracted reference scenarios, and actual301-agent Hermes generation/schema plus nine behavior tests. These are local source/contract checks, not live-model agent performance or production proof.