{{ message }}
Support numeric constraints for Decimal types - #692
Closed
cocorigon wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Hey @Siyet! I don't really do much Python anymore, so no, I will not work on this PR again in the near future. So feel free to use this code as you wish! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first time playing around with C, so please feel free to tell me if more micro-optimizations can be achieved. Same for compiler hints, notably for the
MS_INLINEandMS_NOINLINEnearms_check_decimal_constraints(...): I implemented it in a manner similar to what was done for floats for example, though I must admit that I did not quite understand the pattern for when to use each.Also, I added a DevContainer for easier setup for newcomers to the project.
Closes #683.