{{ message }}
Move msgpack value classes to another project msgpack-value#571
Draft
dmikurube wants to merge 5 commits intomsgpack:mainfrom
Draft
Move msgpack value classes to another project msgpack-value#571dmikurube wants to merge 5 commits intomsgpack:mainfrom
dmikurube wants to merge 5 commits intomsgpack:mainfrom
Conversation
added 5 commits
May 18, 2021 18:56
…sageTypeException and MessageTypeCastException to msgpack-value
Member
Author
|
@xerial Thanks. Got it. I understand your concerns and plan. Then, I think we'll make a choice of removing
The removal in Embulk API will be much much later to wait for plugins to catch up with the latest manner. But, I believe that making a clear declaration during v0.10 would be reasonable and making things smoother. P.S. You may be interested in this: https://gist.github.com/dmikurube/c48ac6432cb4c2151ff9c75cd253bcd5 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some
org.msgpack.valueclasses (typicallyorg.msgpack.value.Value) are used in method signatures of other software's API/SPI, unfortunately.https://dev.embulk.org/embulk-api/0.10.31/javadoc/org/embulk/spi/PageBuilder.html#setJson-org.embulk.spi.Column-org.msgpack.value.Value-
Against such cases, I was wondering if those value classes are separated in a different Maven artifact so that API/SPI includes only stable
msgpack-value, and implementation is released from dependency hell...Can I hear your thoughts?
I don't stick with the implementation shown in this PR, such as naming, class structures, and else. This PR is just as a basis for discussion. But such a separation is really helpful.