{{ message }}
Repository navigation
Line3: Fix closest point for degenerate segments in distanceSqToLine3(). - #34673
Merged
Merged
Conversation
Mugen87
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issue: #32876
Description
Line3.distanceSqToLine3()writes the closest points into the optionalc1andc2targets. When both segments are degenerate (start equals end), the early return computes the distance withc1.sub( c2 ), soc1ends up holdingp1 - p2instead of the closest point on this segment. #32878 fixed the same problem for the general case, but this branch was left unchanged.The fix keeps
c1andc2as the two points and returnsc1.distanceToSquared( c2 ), like the general case does.The
distanceSqToLine3unit test now covers two degenerate segments and checksc1andc2. It fails ondev(c1is(-1, -1, -1)instead of(1, 1, 1)) and passes with this change.