{{ message }}
BufferGeometryUtils: avoid vertex hash overflow at zero tolerance - #34390
Merged
Mugen87 merged 3 commits intoAug 29, 2026
Conversation
Mugen87
reviewed
Aug 28, 2026
Mugen87
reviewed
Aug 28, 2026
Mugen87
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixed #31550
Description
mergeVertices()used bitwise coercion to truncate each quantized attribute value. Bitwise operations first wrap Numbers to signed 32-bit integers, so a zero or very small tolerance can make distinct vertices collide in the hash.This replaces the coercion with
Math.trunc(), which preserves the full Number range, and adds a regression with positions[0, 8, 0]at zero tolerance. The repeated origin is merged while the vertex at x=8 remains distinct.Validation:
[0, 1, 0].git diff --checkpassed.