{{ message }}
BufferGeometryUtils: Let toTrianglesDrawMode()modify geometries in-place.#33878
Open
Mugen87 wants to merge 1 commit into
Open
BufferGeometryUtils: Let toTrianglesDrawMode()modify geometries in-place.#33878Mugen87 wants to merge 1 commit into
toTrianglesDrawMode()modify geometries in-place.#33878Mugen87 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #27926.
Description
The PR makes sure
BufferGeometryUtils.toTrianglesDrawMode()does not clone the entire geometry anymore. The conversion of a draw mode only requires a different index so the function modifies the given geometry instead.This opens up a fix for #27926. By moving the draw mode conversion to
loadGeometries()instead,GLTFLoaderno longer duplicates attribute data. For theoval.gltftest asset that means:Since the PR changes the behavior of
toTrianglesDrawMode(), this change must be noted in the migration guide. Apps can easily restore the previous behavior by just cloning the geometry before usingtoTrianglesDrawMode().