{{ message }}
Repository navigation
feat: delete last-seen BQ rows as part of record purge - #2672
Merged
Merged
Conversation
chenba
force-pushed
the
feat/purge-last-seen-on-acct-del-stor-691
branch
from
October 19, 2026 16:28
33a73a2 to
62b9bd3
Compare
Because: - we should delete an account's last-seen records in BQ when the account is deleted This commit: - deletes the account's last-seen records from the staging and final BQ tables as part of the record purge job - increases the default grace period slightly to account for upload delays of BQ last-seen rows
chenba
force-pushed
the
feat/purge-last-seen-on-acct-del-stor-691
branch
from
October 19, 2026 17:19
62b9bd3 to
cdb6b12
Compare
pjenvey
reviewed
Oct 21, 2026
Member
There was a problem hiding this comment.
IMO I really don't see this and the test_last_seen_job_error_raises test (along with the associated 2 classes) as worth having
I'm leaning the same direction for test_last_seen_respects_max_records as well
Co-authored-by: Philip Jenvey <pjenvey@underboss.org>
pjenvey
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Issue(s)
Closes STOR-691