fix(scoring): average finite rotation logits without overflow by rudycelekli · Pull Request #51 · mohit67890/imajev · GitHub
Skip to content

fix(scoring): average finite rotation logits without overflow - #51

Open
rudycelekli wants to merge 1 commit into
mohit67890:mainfrom
rudycelekli:fix/rotation-finite-logit-averages-20261010
Open

rudycelekli wants to merge 1 commit into
mohit67890:mainfrom
rudycelekli:fix/rotation-finite-logit-averages-20261010

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Cancel a finite position bias across presentation orders without overflowing log-probability differences. Previously full rotations of finite ±1e308 logits produced non-finite averages and failed instead of yielding equal probabilities. Per-order normalization constants cancel in the final softmax, so average divided logits with math.fsum before normalization; reported raw_logits now contain the averaged logits.

Validation: the valid baseline regression fails; 67 focused contract/generation/layout tests pass with one existing skip. The available CPU suite has 660 passes, 135 skips and three dependency/fixture failures reproduced on the pinned baseline. Full collection also encounters four missing-Torch modules. Those limits are preserved; no full-suite pass, model evaluation or GPU result is claimed.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant