{{ message }}
Repository navigation
fix(scoring): average finite rotation logits without overflow - #51
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Cancel a finite position bias across presentation orders without overflowing log-probability differences. Previously full rotations of finite ±1e308 logits produced non-finite averages and failed instead of yielding equal probabilities. Per-order normalization constants cancel in the final softmax, so average divided logits with math.fsum before normalization; reported raw_logits now contain the averaged logits.
Validation: the valid baseline regression fails; 67 focused contract/generation/layout tests pass with one existing skip. The available CPU suite has 660 passes, 135 skips and three dependency/fixture failures reproduced on the pinned baseline. Full collection also encounters four missing-Torch modules. Those limits are preserved; no full-suite pass, model evaluation or GPU result is claimed.