{{ message }}
Repository navigation
fix: validate prediction identities before paired comparisons - #30
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Apply the existing score-command prediction ID checks to compare. Previously duplicate rows silently overwrote predictions and rows outside the selected split disappeared, yielding a plausible paired comparison from an invalid submission.
Evidence and validation
ccf586d43d2a580319b6535c893668904d909eb9with the regression tests in this PR.python -m pytest -p no:cacheprovider -q tests/test_compare_prediction_ids.py tests/test_imajev_bench_v2.py tests/test_imajev_bench_scoring.pypass after the patch; pre-patch failures are preserved locally.git diff --checkpasses.mlx_vlmdependency; two import the absenttest_p3_labeltrainfixture helper.python -m pytest -p no:cacheprovider -q: Exact PR head7daff21b2089: 4 failed, 718 passed, 136 skipped, 35 warnings in 59.64s. Only those same four upstream/environment failures remain; this patch introduces no additional failures.Contract references
cli.mainscore already requires unique string IDs inside the selected split; compare now reuses that same validation. No change to missing-prediction scoring.AI assistance
Prepared with AI assistance; the reproduction, patch and tests were reviewed before submission.