{{ message }}
[bazel] Set modular_config scope for host_modular_config#6687
Open
keith wants to merge 1 commit into
Open
Conversation
This sets `modular_config` to be inherited from `host_modular_config` when in the exec configuration. This stuff is still changing upstream but since this repo uses such a new bazel version this works. Before this any places that `select()` on `modular_config` in the exec transition would get the default value. bazelbuild/bazel#28320
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Bazel build setting for modular_config to introduce an execution-scope mapping to a host-specific modular config flag.
Changes:
- Adds a
scopeattribute to thestring_flag(name = "modular_config", ...)definition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets
modular_configto be inherited fromhost_modular_configwhen in the exec configuration. This stuff is still changing upstream
but since this repo uses such a new bazel version this works.
Before this any places that
select()onmodular_configin the exectransition would get the default value.
bazelbuild/bazel#28320