{{ message }}
fix(dim): resolve infinite recursion in Dim.__rfloordiv__#6664
Open
101-AbdulKhan wants to merge 8 commits into
Open
fix(dim): resolve infinite recursion in Dim.__rfloordiv__#6664101-AbdulKhan wants to merge 8 commits into
101-AbdulKhan wants to merge 8 commits into
Conversation
When evaluating int // Dim, Python calls Dim.__rfloordiv__(int). The previous implementation re-evaluated lhs // self, which triggered the same dispatch chain infinitely causing a RecursionError. Fix: wrap lhs in Dim() before calling // self, matching the pattern already used by __radd__ and __rmul__. Adds two regression tests: - test_static_dim_rfloordiv_int: verifies int // StaticDim works correctly - test_static_dim_rfloordiv_zero_division_raises: verifies ZeroDivisionError is raised when the denominator Dim is zero Fixes modular#6595
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When evaluating int // Dim, Python calls Dim.rfloordiv(int). The previous implementation re-evaluated lhs // self, which triggered the same dispatch chain infinitely, causing a RecursionError.
Fix: wrap lhs in Dim() before calling // self, matching the pattern already used by radd and rmul.
Adds two regression tests:
Fixes #6077
Type of change
Motivation
This is a trivial one-line bug fix.
int // StaticDimcurrently triggers aRecursionErrordue to recursive redispatch inDim.__rfloordiv__.What changed
max/python/max/graph/dim.py:return lhs // selftoreturn Dim(lhs) // selfmax/tests/tests/graph/test_dim.py:test_static_dim_rfloordiv_inttest_static_dim_rfloordiv_zero_division_raisesTesting
./bazelw test //max/tests/tests/graph:test_dimint // StaticDimworksZeroDivisionErrorLinked issue
Fixes #
Type of change
Motivation
What changed
Testing
Checklist
agreed-upon, or this is a trivial fix that does not need prior
approval
smaller PRs where possible (see
pull request sizes)
./bazelw run formatto format my changesAssisted-by:trailer in my commit message or this PR description (seeAI Tool Use Policy)